Sanitize text before making repr_html #3378
Conversation
stephenworsley
changed the title
There was a problem hiding this comment.
Good thinking to sanitize the inputs for stray html. I think we could simplify the approach and I've made comments to that effect below. Again we're also missing tests for these changes. It would be good to see a test for every string element that gets added to the html repr confirming that stray html is being sanitized.
|
So it looks like the html module was added to python in version 3.2 so this is not compatible with 2.7. That said, the escape function isn't that complicated as it just involves a couple of string replace operations (In the form i'm using, it could be written in about 5 lines). |
👍 Support this decision (with the expectation that it will be reversed once Iris goes Python 3+ only!) |
|
@stephenworsley I've moved this PR back into to the "In progress" column as it looks like this is still requiring tests |
# Conflicts: # lib/iris/experimental/representation.py # lib/iris/tests/stock/__init__.py
|
@stephenworsley @lbdreyer Is this PR making the cut for If so, it needs a bit of ❤️ and should now target the Otherwise, let's target |
I think it's a bit too late, unfortunately. And I'm a little unsure about the approach. |
stephenworsley
force-pushed
the
clean_html
branch
2 times, most recently
from
c20036f
to
0967c12
Compare
stephenworsley
force-pushed
the
clean_html
branch
from
0967c12
to
3d185a5
Compare
|
Hi @stephenworsley However, I unfortunately found that none of the tests in So if you examine the Travis log + search for "representation", it is running Naturally, this means they do not pass 🤕 . |
|
Re: stephenworsley#5 OWOK, I think 👍 |
lib/iris/tests/unit/experimental/representation/test_CubeListRepresentation.py
Outdated
Show resolved
Hide resolved
Addresses #3377. May be relevant to #3313.
All text which is taken from a cube and put into its repr_html is now passed through
html.escape()first.